Add Etc signature #1006
Merged
Add Etc signature #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
commented
May 23, 2022
ybiquitous
commented
May 23, 2022
ybiquitous
force-pushed
the
add-etc-module-signature
branch
from
be26fe7 to
16e787b
Compare
The base of this change is generated by the following steps: 1. Run `RUBYOPT=-retc bundle exec exe/rbs prototype runtime --merge Etc > stdlib/etc/0/etc.rbs` 2. Run `RUBYOPT=-retc bundle exec exe/rbs prototype runtime --merge Etc::Group >> stdlib/etc/0/etc.rbs` 3. Run `RUBYOPT=-retc bundle exec exe/rbs prototype runtime --merge Etc::Passwd >> stdlib/etc/0/etc.rbs` 4. Run `bundle exec exe/rbs annotate stdlib/etc/0/*.rbs` 5. Run `bundle exec rake 'generate:stdlib_test[Etc]'` Then, I've edited the files manually. See https://docs.ruby-lang.org/en/3.1/Etc.html
ybiquitous
force-pushed
the
add-etc-module-signature
branch
from
186b294 to
012c49e
Compare
|
@soutaro Thanks for the review. I've put it in one commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base of this change is generated by the following steps:
RUBYOPT=-retc bundle exec exe/rbs prototype runtime --merge Etc > stdlib/etc/0/etc.rbsRUBYOPT=-retc bundle exec exe/rbs prototype runtime --merge Etc::Group >> stdlib/etc/0/etc.rbsRUBYOPT=-retc bundle exec exe/rbs prototype runtime --merge Etc::Passwd >> stdlib/etc/0/etc.rbsbundle exec exe/rbs annotate stdlib/etc/0/*.rbsbundle exec rake 'generate:stdlib_test[Etc]'Then, I've edited the files manually.
See https://docs.ruby-lang.org/en/3.1/Etc.html
Note: It's been a while since I've written, so feel free to point out any style violations, insufficient test cases, etc.