Always skip CR explicitly #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadoxV5
reviewed
Sep 23, 2022
| @@ -641,4 +641,10 @@ def test_parse_method_type2 | |||
| assert_equal "foo?: String, bar!: Integer", method_type.type.param_to_s | |||
| end | |||
| end | |||
|
|
|||
| def test_neline_inconsitency | |||
There was a problem hiding this comment.
wait.
Suggested change
| def test_neline_inconsitency | |
| def test_newline_inconsistency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1111
\r\n, but WSL is\nThis PR explicitly ignores
\reven in non-windows environment.Note that this workaround is unnecessary when everything is done correctly: the source code is written in Windows and read in Windows because Ruby converts
\r\nto\nautomatically when reading with text mode API. (Andrbs parsereads the source in text mode.) (This assumption is unrealistic especially for newbies, according to #1111 and I agree with it.)