Implement rbs subtract command
#1287
Merged
+1,103
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
subtract
branch
2 times, most recently
from
6eeae2d
to
6b89bc1
Compare
pocke
force-pushed
the
subtract
branch
2 times, most recently
from
b80de2e
to
e37ca45
Compare
Because we do not need TypeNameResolver. It resolves type name, but we just need to resolve class/constant names which are statically definitive.
Because duplicated interface is not allowed
Because now filter_members does not support interface
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
rbs subtractcommand.Design: https://hackmd.io/seoMijXwRdG2uFITm2lLqw
I'm trying this feature on my private project, and it works well.
Limitations
This PR doesn't solve the limitations described in the design doc.
The limitations rarely affect the real applications. So I think we do not need to remove the limitations in this PR.