Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathname#mkpath and Pathname#rmtree returns self from Ruby 3.4 #2048

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Pathname#mkpath and Pathname#rmtree returns self from Ruby 3.4 #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/pathname/0/pathname.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ class Pathname
#
# See FileUtils.mkpath and FileUtils.mkdir_p
#
def mkpath: () -> nil
def mkpath: () -> self

# <!--
# rdoc-file=ext/pathname/lib/pathname.rb
Expand Down Expand Up @@ -1106,7 +1106,7 @@ class Pathname
#
# See FileUtils.rm_rf
#
def rmtree: () -> void
def rmtree: () -> self

# <!--
# rdoc-file=ext/pathname/lib/pathname.rb
Expand Down
10 changes: 4 additions & 6 deletions test/stdlib/Pathname_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,13 +458,11 @@ def test_mkdir
end

def test_mkpath
if_ruby(... 3.4) do
Dir.mktmpdir do |dir|
dir = Pathname(dir)
Dir.mktmpdir do |dir|
dir = Pathname(dir)

assert_send_type '() -> nil',
assert_send_type '() -> Pathname',
dir + 'a/b/c', :mkpath
end
end
end

Expand Down Expand Up @@ -644,7 +642,7 @@ def test_rmtree
Dir.mktmpdir do |dir|
target = Pathname(dir).join('target')
target.mkdir
assert_send_type '() -> void',
assert_send_type '() -> Pathname',
target, :rmtree
end
end
Expand Down
Loading