Clean up temporary workarounds from templated code #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate the c/h code for constant definitions and object initialization. We make sure the Rake task builds the required templates so we can compile the extension. Co-authored-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Ultimately we want to separate the pure C implementation files (under `src/` and `include/`) from the Ruby extension files (under `ext/rbs_extension`). This change allow us to build the Ruby extension using files outside of the `ext/rbs_extension` directory. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
We picked a longer named that’s prefixed with `_`, so it’s less likely to collide with any templated fields names (which end up as parameters to these functions).
This commit removes the `c_name` special cases from our templated code. Instead, we rename the C identifiers to always match their Ruby counterparts (which are the ones that matter, since they get exposed as keyword argument labels on the class’ constructors).
amomchilov
commented
Nov 27, 2024
| <%- node.fields.each do |field| -%> | ||
| rb_hash_aset(<%= hash_var %>, ID2SYM(rb_intern("<%= field.name %>")), <%= field.c_name %>); | ||
| rb_hash_aset(_init_kwargs, ID2SYM(rb_intern("<%= field.name %>")), <%= field.name %>); |
There was a problem hiding this comment.
We picked _init_kwargs instead of a name like kwargs, args, etc. to make it less likely that it collides with the name of a parameter to this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up built on top of #2098. It doesn't change any of its behaviour, but just removes the temporary workarounds that we used to minimize the diff of #2098.
Only the last 4 commits are new to this PR, the rest just come from #2098.
This PR is best reviewed commit-by-commit.