Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutex_m support #2115

Merged
merged 3 commits into from
Dec 4, 2024
Merged

mutex_m support #2115

merged 3 commits into from
Dec 4, 2024

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Dec 4, 2024

@soutaro soutaro added this to the RBS 3.7 milestone Dec 4, 2024
"`#{name}` is included in the RBS dependencies of `#{from_gem}`, but the type definition as a stdlib in rbs-gem is deprecated. Add `#{name}` (#{version}) to the dependency of your Ruby program to use the gem-bundled type definition."
}
else
RBS.logger.info {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is INFO message because the end-user is not responsible for the dependencies: of the type definition.

@soutaro soutaro added this pull request to the merge queue Dec 4, 2024
Merged via the queue into master with commit d923c4c Dec 4, 2024
18 checks passed
@soutaro soutaro deleted the mutex-m branch December 4, 2024 08:08
@soutaro
Copy link
Member Author

soutaro commented Dec 4, 2024

stdlib/minitest has mutex_m as RBS dependency. But we cannot delete it because the gem doesn't declare dependency to mutex_m gem.

@ksss
Copy link
Collaborator

ksss commented Dec 4, 2024

RBS dependency of stdlib/minitest has been removed by #2093 .

@soutaro soutaro added the Released PRs already included in the released version label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants