Allows the use of a path list as RBS_SKIP_TESTS #2612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The I think opening a PR for |
In ruby/ruby test-bundled-gems, rbs has many failures on Windows. Currently we ignore all failures in this test totally, but that is the test-run makes no sense but just wastes times. So I want to also specify another file for the tests to be skipped only on Windows, in addition to the platform independent skipping list file, that we are using already.
soutaro
added a commit
that referenced
this pull request
Aug 14, 2025
Allows the use of a path list as RBS_SKIP_TESTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ruby/ruby test-bundled-gems, rbs has many failures on Windows. Currently we ignore all failures in this test totally, but that is the test-run makes no sense but just wastes times.
So I want to also specify another file for the tests to be skipped only on Windows, in addition to the platform independent skipping list file, that we are using already.