Deprecate top-level float #2695
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ParadoxV5 , @soutaro , and @ksss . Thoughts? |
Perhaps we could use a convenience alias for |
|
It'd only really be used in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the top-level
floattype, as it's mostly pointless and is not an implicit conversion (like all the other top-level alias types).Most places you'd expect to use it (eg
Mathfunctions) actually requireNumeric & _ToF. There's only a few minor edge-cases in the stdlib that use floats directly (egRegexp.timeout=), but they can instead use_ToF.