Skip to content

Skip io/wait tests for methods deleted in Ruby 4 #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XrXr wants to merge 1 commit into from
Closed

Skip io/wait tests for methods deleted in Ruby 4 #2706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions test/stdlib/IO_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,20 +528,22 @@ class IOWaitTest < Test::Unit::TestCase
def test_readyp
# This method returns true|false in Ruby 2.7, nil|IO in 3.0, and true|false in 3.1.

IO.pipe.tap do |r, w|
assert_send_type(
"() -> untyped",
r, :ready?
)
end
if_ruby(..."4.0.0", skip: false) do
IO.pipe.tap do |r, w|
assert_send_type(
"() -> untyped",
r, :ready?
)
end

IO.pipe.tap do |r, w|
w.write("hello")
IO.pipe.tap do |r, w|
w.write("hello")

assert_send_type(
"() -> untyped",
r, :ready?
)
assert_send_type(
"() -> untyped",
r, :ready?
)
end
end
end

Expand Down Expand Up @@ -584,11 +586,13 @@ def test_wait_writable
end

def test_nread
IO.pipe.tap do |r, w|
assert_send_type(
"() -> Integer",
r, :nread
)
if_ruby(..."4.0.0", skip: false) do
IO.pipe.tap do |r, w|
assert_send_type(
"() -> Integer",
r, :nread
)
end
end
end

Expand Down