-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad performance during mixin resolution #1126
Comments
Earlopain
added a commit
to Earlopain/rdoc
that referenced
this issue
Jun 27, 2024
Potential fix for ruby#1126
Earlopain
added a commit
to Earlopain/rdoc
that referenced
this issue
Jun 27, 2024
Potential fix for ruby#1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rails recently moved some includes from being dynamic to explicit in rails/rails#52185 which means rdoc was now able to document a bit more. This had the side-effect of rdoc taking about 8 hours on that single file alone. Temporary solution was to wrap these in startdoc/stopdoc like rails/rails#52185
I tried to investigate a bit and found this comment that mentions O(n!)
rdoc/lib/rdoc/mixin.rb
Lines 68 to 73 in 4b84660
I also have a potential fix which at least resolves this and tests pass. Check it out at #1127.
Repro:
The text was updated successfully, but these errors were encountered: