Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/rdoc/test_rdoc_generator_json_index.rb: Use assert_equal. #1049

Merged
merged 1 commit into from
Oct 30, 2023
Merged

test/rdoc/test_rdoc_generator_json_index.rb: Use assert_equal. #1049

merged 1 commit into from
Oct 30, 2023

Conversation

junaruga
Copy link
Member

@junaruga junaruga commented Oct 30, 2023 •
edited
Loading

Related to #1048.

Use assert_equal instead of of assert. It's better because assert_equal prints the values when it fails. I want to see the actual values in the failing case.

The assert_equal prints the values like this.

assert_equal 'a', 'b', 'dummy'

dummy
<"a"> expected but was
<"b">

@junaruga
test/rdoc/test_rdoc_generator_json_index.rb: Use assert_equal instead…
29efc35 
… of assert.

It's better because assert_equal prints the values when it fails.
@junaruga junaruga merged commit 91d40ce into ruby:master Oct 30, 2023
21 checks passed
@junaruga junaruga deleted the wip/test-rdoc-generator-json-index-assert-equal branch October 30, 2023 16:21
@junaruga
Copy link
Member Author

Let me merge this PR. I think that no one is disturbed by this small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@junaruga