Modernize RDoc Darkfish template CSS #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
reviewed
Aug 19, 2024
st0012
force-pushed
the
improve-styling
branch
from
126a05a
to
1c0b028
Compare
|
@paracycle Thanks for the suggestions. I've extracted fonts into variables as well as cleaned up some variable usages. |
zenspider
approved these changes
Aug 19, 2024
st0012
force-pushed
the
improve-styling
branch
from
1c0b028
to
0518d4e
Compare
- Update color scheme with muted green tones and improved contrast - Enhance readability by adjusting font sizes and weights - Improve code block styling with a light gray background - Refactor layout for better responsiveness and sidebar presentation - Standardize link styles across the document - Implement CSS variables for easier theme customization - Adjust heading styles for better visual hierarchy - Enhance table and list styling for improved readability - Optimize search field and navigation toggle appearance - Improve method detail and documentation section styling - Reorganize css and overhaul the sidebar design - Improve code block's syntax highlighting
st0012
force-pushed
the
improve-styling
branch
from
0518d4e
to
36114ba
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 24, 2024
(ruby/rdoc#1157) - Update color scheme with muted green tones and improved contrast - Enhance readability by adjusting font sizes and weights - Improve code block styling with a light gray background - Refactor layout for better responsiveness and sidebar presentation - Standardize link styles across the document - Implement CSS variables for easier theme customization - Adjust heading styles for better visual hierarchy - Enhance table and list styling for improved readability - Optimize search field and navigation toggle appearance - Improve method detail and documentation section styling - Reorganize css and overhaul the sidebar design - Improve code block's syntax highlighting ruby/rdoc@6cde9edadb
|
@st0012 TY for the update! I notices that some pages (here's an example) are hard to read on mobile. |
|
Do you mean because of the initial zoom? |
|
Yeah. Users shouldn't need to zoom in/out to read on mobile. It's like the text doesn't wrap or something. I'm AFK so I can't tell exactly what's going on |
nobu
reviewed
Oct 25, 2024
Comment on lines
+240
to
+241
| nav ul li details > summary { | ||
| list-style: none; /* Remove the default marker */ |
There was a problem hiding this comment.
Unfortunately, this still doesn't work in Safari 18.1.
summary::-webkit-details-marker {display: none;} is needed.
Was it intentional to make label lists and note lists render the exact same way? IMO, it's useful to have the two different definition list styles, even though I'd love for one or both of them to be slightly different from what they are in 6.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result
rdoc-theme-demo.mp4
Comparisions
For detail comparison, I recommend clicking into images.
Left: old; Right: new
RDocRuby official docs