Remove dead or unnecessary methods/attributes #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rdoc with
|
| Latest commit: |
acb2e2b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1cb6e909.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://remove-dead-methods.rdoc-6cd.pages.dev |
st0012
commented
Mar 16, 2025
| @c1.each_extend do |extend| extend.module end # cache extended modules | ||
|
|
||
| @m1_m2.document_self = nil | ||
| assert @m1_m2.remove_from_documentation? |
There was a problem hiding this comment.
These same test assertions actually appear in other tests like test_update_includes_with_colons as well. So we don't need to keep them here either.
tompng
reviewed
Mar 16, 2025
st0012
force-pushed
the
remove-dead-methods
branch
from
696f5dd to
d1c838c
Compare
st0012
force-pushed
the
remove-dead-methods
branch
from
d1c838c to
acb2e2b
Compare
alexisbernard
added a commit
to BaseSecrete/rorvswild-theme-rdoc
that referenced
this pull request
Apr 24, 2025
Some methods have been removed in ruby/rdoc#1315.
alexisbernard
added a commit
to BaseSecrete/rorvswild-theme-rdoc
that referenced
this pull request
Apr 24, 2025
Some methods have been removed in ruby/rdoc#1315.
alexisbernard
added a commit
to BaseSecrete/rorvswild-theme-rdoc
that referenced
this pull request
Apr 25, 2025
Some methods have been removed in ruby/rdoc#1315.
alexisbernard
added a commit
to BaseSecrete/rorvswild-theme-rdoc
that referenced
this pull request
Apr 25, 2025
Some methods have been removed in ruby/rdoc#1315.
alexisbernard
added a commit
to BaseSecrete/rorvswild-theme-rdoc
that referenced
this pull request
Apr 25, 2025
Some methods have been removed in ruby/rdoc#1315.
|
This change broke sdoc, because we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 types of targets in this PR: