Enable Style/MethodDefParentheses rule
#1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs-enable-method-def-parenthesis
branch
from
226e714 to
02484f8
Compare
Enable parenthesis for method definitions so that we have more consistency in the codebase. In addition to that, I disabled running RuboCop on generated parser files.
`$ bundle exec rubocop -a` after the configuration changes
vinistock
force-pushed
the
vs-enable-method-def-parenthesis
branch
from
02484f8 to
610b90b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RDoc codebase has very few conventions. I think it would be nice to standardize the style of the code a bit more. I propose we start requiring parenthesis in method definitions, which in my opinion makes the code more readable.
This PR just changes the configurations and then runs
bundle exec rubocop -a. I also excluded generated files from linting.