-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch download-test_readline to ruby script #127
Conversation
When removing appveyor.yml files, it may fail, as AppVeyor can be configured to run default scripts if no yml file is present. If one checks the AppVeyor settings page for the project, the 'left side' menu's bottom option is 'Delete project'. That's the easy way. Otherwise, the menu options 'Build', 'Test', & 'Deployment' items all have options that should be set to 'Off'. I think doing that will not run any CI, but I'm not sure... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a good idea to manage the list in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing. I think "Delete AppVeyor & Travis" should be separated. Would you split the commit to another Pull Request?
cda3f9b
to
7d867ea
Compare
Thank you. Done, see PR #128. |
7d867ea
to
dff2855
Compare
dff2855
to
73d2e3c
Compare
Thanks. I realized last night while AFK that the code may not be thread safe with the handling of the file info array/matrix. If so, I'll do a PR... |
All the discussions ware great. And thank you so much for your careful consideration. Your way what you did covers where I couldn't find problems.
You're always welcome! |
Thanks, I'm glad I could help. Thank you for reline, as it's a big improvement for Windows Ruby. |
Instead of using platform specific scripts to download readline test files from ruby/ruby, use a Ruby script.
Didn't go crazy with error checking, as GitHub connecting to GitHub should be reliable. It does fail when a file does not exist (response.message != 'OK').
More changes are coming to using Ruby on Actions, and a cross platform script will be helpful.