Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not implemented variables #699

Merged
merged 1 commit into from
May 5, 2024

Conversation

ima1zumi
Copy link
Member

@ima1zumi ima1zumi commented May 5, 2024

Perhaps these were described as TODO comments, but it is difficult to see that these functions are not available, so they should be removed.

  • bind-tty-special-chars
  • blink-matching-paren
  • byte-oriented
  • enable-keypad
  • expand-tilde
  • history-preserve-point
  • horizontal-scroll-mode
  • input-meta
  • mark-directories
  • mark-modified-lines
  • mark-symlinked-directories
  • match-hidden-files
  • meta-flag
  • output-meta
  • page-completions
  • prefer-visible-bell
  • print-completions-horizontally
  • show-all-if-unmodified
  • visible-stats

I confirmed that grep does not hit with either hyphens or underscores.

git grep -e bind-tty-special-chars -e blink-matching-paren -e byte-oriented -e enable-keypad -e expand-tilde -e history-preserve-point -e horizontal-scroll-mode -e input-meta -e mark-directories -e mark-modified-lines -e mark-symlinked-directories -e match-hidden-files -e meta-flag -e output-meta -e page-completions -e prefer-visible-bell -e print-completions-horizontally -e show-all-if-unmodified -e visible-stats
git grep -e bind_tty_special_chars -e blink_matching_paren -e byte_oriented -e enable_keypad -e expand_tilde -e history_preserve_point -e horizontal_scroll_mode -e input_meta -e mark_directories -e mark_modified_lines -e mark_symlinked_directories -e match_hidden_files -e meta_flag -e output_meta -e page_completions -e prefer_visible_bell -e print_completions_horizontally -e show_all_if_unmodified -e visible_stats

@ima1zumi ima1zumi marked this pull request as ready for review May 5, 2024 04:38
Copy link
Member

@tompng tompng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tompng tompng merged commit 328699e into ruby:master May 5, 2024
40 checks passed
@ima1zumi ima1zumi deleted the remove-not-implemented-variables branch May 5, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants