Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly require fiddle #779

Closed
wants to merge 1 commit into from
Closed

explicitly require fiddle #779

wants to merge 1 commit into from

Conversation

kbrock
Copy link

@kbrock kbrock commented Nov 14, 2024

fiddle has been removed from ruby 3.5 standard gems.
This makes the gem dependency explicit.

ruby-3.3.5/lib/ruby/3.3.0/reline.rb:9: warning:
fiddle was loaded from the standard library,
but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add fiddle to your Gemfile or gemspec to silence this warning.

`fiddle` has been removed from ruby 3.5 standard gems.
This makes the gem dependency explicit.

```
ruby-3.3.5/lib/ruby/3.3.0/reline.rb:9: warning: fiddle was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add fiddle to your Gemfile or gemspec to silence this warning.
```
@st0012
Copy link
Member

st0012 commented Nov 14, 2024

We're leaning towards dropping the usage of fiddle instead in #769

@ima1zumi
Copy link
Member

In windows.rb, we’re using fiddle. However, adding fiddle as a dependency might make gem install difficult in certain environments, so I’d prefer to avoid including it as a dependency. (But I have no idea...)

require 'fiddle/import'

@kbrock
Copy link
Author

kbrock commented Nov 18, 2024

Thank you

@kbrock kbrock closed this Nov 18, 2024
@kbrock kbrock deleted the fiddle branch November 18, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants