Refactor handling key in LineEditor #799
Merged
+57
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the complicated flow of waiting_proc, wrap_method_call and run_for_operation
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 3, 2025
(ruby/reline#799) Simplify the complicated flow of waiting_proc, wrap_method_call and run_for_operation ruby/reline@72c0ec0425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the complicated flow of waiting_proc, wrap_method_call and run_for_operation.
wrap_method_call.method_objto another method.process_key@vi_waiting_operatorinprocess_keyand inrun_for_operators__send__instead ofwrap_method_call(@vi_waiting_operator, ...)because@vi_waiting_operatoris not a key-bounded method.ed_argument_digitin specific condition. Instead, implement vi_zero and ed_digit correctly.