Refactor utf-8 strings and invalid strings in test code #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the problem mentioned in the source code comment in input_keys.
"\M-[char]"
should be removed from test code because it is an invalid byte sequence string.Reline only accepts
"\e[char]"
which is sent byMeta-[char]
key input in modern terminal emulators.After invalid byte sequence are removed, we don't need
convert
option in methodinput_keys
because valid strings does not need to skip convert.Other changes
def convert_str(input)
can be simpler.If the input needs
unicode_normalize
before conversion, then the prerequisites of the test (input unicode-unnormalized text) are broken. We just need to omit the test if the test encoding is not utf-8.