Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Securerandom should be always available #59

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Securerandom should be always available #59

merged 1 commit into from
Dec 10, 2024

Conversation

deivid-rodriguez
Copy link
Contributor

Securerandom has been there since 2007.

The commit that started rescuing the LoadError was introduced in 2008, so I believe the fallback code has never been used?

olleolleolle
olleolleolle approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this simplification.

@deivid-rodriguez
Copy link
Contributor Author

@hsbt Not urgent but I wonder your thoughts here :)

@deivid-rodriguez
Copy link
Contributor Author

Ping @hsbt :)

@hsbt hsbt merged commit 04f0438 into ruby:master Dec 10, 2024
25 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/securerandom-is-always-there branch December 10, 2024 10:14
@deivid-rodriguez
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @olleolleolle @hsbt