Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: REXML accepts unclosed DOCTYPE #152

Closed
makenowjust opened this issue Jun 18, 2024 · 0 comments · Fixed by #153
Closed

BUG: REXML accepts unclosed DOCTYPE #152

makenowjust opened this issue Jun 18, 2024 · 0 comments · Fixed by #153

Comments

@makenowjust
Copy link
Contributor

makenowjust commented Jun 18, 2024 •
edited
Loading

Currently, REXML accepts unclosed DOCTYPE declarations.

require "rexml/document"

REXML::Document.new("<!DOCTYPE foo [")
# => <UNDEFINED> ... </>
# No exceptions are raised!

It seems strange and it should be fixed.
makenowjust added a commit to makenowjust/rexml that referenced this issue Jun 18, 2024
@makenowjust
Reject unclosed DOCTYPE on parsing
4af4265 
Fix ruby#152
@makenowjust makenowjust mentioned this issue Jun 18, 2024
Merged
@kou kou closed this as completed in #153 Jun 19, 2024
kou added a commit that referenced this issue Jun 19, 2024
@makenowjust @kou
Reject unclosed DOCTYPE on parsing (#153)
f704011 
Fix #152

---------

Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject unclosed DOCTYPE on parsing makenowjust/rexml
1 participant
@makenowjust