Implement the JS::Object#to_b method. #247
Closed
+39
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A boolean value in JavaScript is always a
JS::Object
instance from Ruby's point of view.Therefore, if we use the boolean value returned by a JavaScript function as the condition for an if expression in Ruby, the if expression will always be true.
Think of
searchParams
as an instance of JavaScript'sSearchParams
class.This is not the expected behavior.
Therefore, we can implement the
JS::Object#to_b
method to convert JavaScript boolean values to Ruby boolean values.It is intended to be used in the following ways:
I implemented the
to_b
method by referring to the implementation of theto_s
method.If you prefer a different implementation, please let me know.