Delete ANYARGS #2404
Closed
Delete ANYARGS #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ko1 missed this in d5893b9.
Nobu missed it in f0e73fc.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. Let's start from making rb_block_call_func_t strict, and apply RB_BLOCK_CALL_FUNC_ARGLIST liberally.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit deletes ANYARGS from struct vm_ifunc, but in doing so we also have to decouple the usage of this struct in compile.c, which (I think) is an abuse of ANYARGS.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit makes rb_iterate free from ANYARGS.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit deletes ANYARGS from rb_rescue / rb_rescue2, which revealed many arity / type mismatches.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit deletes ANYARGS from rb_ensure, which also revealed many arity / type mismatches.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit deletes ANYARGS from rb_catch, and fixes some bugs revealed by that.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit deletes ANYARGS from rb_proc_new / rb_fiber_new, and applies RB_BLOCK_CALL_FUNC_ARGLIST wherever necessary.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit deletes ANYARGS from rb_thread_create, which seems very safe to do.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit adds function prototypes for struct st_hash_type. Honestly I don't understand why they were commented out at the first place.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit uses rb_gvar_getter_t / rb_gvar_setter_t for rb_define_hooked_variable / rb_define_virtual_variable which revealed lots of function prototype inconsistencies. Some of them were literally decades old, going back to dda5dc0.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit adds function prototypes for rb_hash_foreach / st_foreach_safe. Also fixes some prototype mismatches.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This commit adds a function prototype for rb_ivar_foreach. Luckily this change revealed no problematic usage of the function.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. There is only one usage of MEMO::u3::func in load.c (where void Init_Foobar(vodi) is registered) so why not just be explicit.
After 5e86b00, I now think ANYARGS is dangerous and should be extinct. This function has only one call site so adding appropriate prototype is trivial.
They lack portability. See also https://travis-ci.org/shyouhei/ruby/jobs/577164015
|
Will merge this. |
|
done @ 1663d34 |
matzbot
pushed a commit
that referenced
this pull request
Aug 27, 2019
in response to the declaration change in e3fc305. Fixing the AppVeyor mswin CI failure: https://ci.appveyor.com/project/ruby/ruby/builds/26980881/job/2j6h1qwjnbc8cpop ref: #2404
matzbot
pushed a commit
that referenced
this pull request
Sep 6, 2019
Compilation of extension libraries written in C++ are reportedly broken due to #2404 The root cause of this issue was that the definition of ANYARGS differ between C and C++, and that of C++ is incompatible with the updated ones. We are using the incompatibility against itself. In C++ two distinct function prototypes can be overloaded. We provide the old, ANYARGSed prototypes in addition to the current granular ones; and let the older ones warn about types.
|
Since a569bc0 adds back a compatibility layer for C++, what should C++ extensions do as a best practice going forward? |
|
@sodabrew Currently, if you are using C++ and stick to old style, your compiler complains about it but compiles nonetheless. I suggest there are two possible best practices:
|
|
@shyouhei Just to give you a note: FXRuby failed to build due to latest changes to ANYARGS and C++ type checking/depreciation. I had to do a bunch of changes to make it to compile again and not raising any warnings. So the ANYARGS changes in ruby break backward compatibility in some cases. However I'm glad to see these changes! I always wondered, why ruby's C-API makes overly much use of ANYARGS. It also revieled some broken function signatures in FXRuby. |
eregon
pushed a commit
to eregon/rubyspec
that referenced
this pull request
Sep 29, 2019
in response to the declaration change in e3fc30564e9466d6926f9d25a090dcf787bd5c33. Fixing the AppVeyor mswin CI failure: https://ci.appveyor.com/project/ruby/ruby/builds/26980881/job/2j6h1qwjnbc8cpop ref: ruby/ruby#2404
|
@larskanis Thank you! The build failure seems related to 17a1366. @nobu Can you take a look? |
70 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, I understand it's very difficult to implement
rb_define_methodwithoutANYARGS. But how aboutrb_rescue? Because that function has only one usage, I see no reason for its function prototype to useANYARGS. And here is my changeset to delete such usages.