`bundle update --bundler` is broken in 2.2.32 for git source with `0.0.0.SNAPSHOT` version

[ojab]

Describe the problem as clearly as you can

$ bundle install bundler -v 2.2.32
$ bundle update --bundler
…
The git source https://github.com/….git is not yet checked out. Please run `bundle install`
before trying to start your application

Cannot provide more details ATM since it's non-public project, hopefully it's clear what could cause it due to small amount of commits since 2.2.31.

Did you try upgrading rubygems & bundler?

Yep.

Environment

Bundler       2.2.31
  Platforms   ruby, x86_64-linux
Ruby          2.7.4p191 (2021-07-07 revision a21a3b7d23704a01d34bd79d09dc37897e00922a) [x86_64-linux]
  Full Path   /home/ojab/.rbenv/versions/2.7.4/bin/ruby
  Config Dir  /home/ojab/.rbenv/versions/2.7.4/etc
RubyGems      3.2.32
  Gem Home    /home/ojab/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0
  Gem Path    /home/ojab/.gem/ruby/2.7.0:/home/ojab/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0
  User Home   /home/ojab
  User Path   /home/ojab/.gem/ruby/2.7.0
  Bin Dir     /home/ojab/.rbenv/versions/2.7.4/bin
Tools         
  Git         2.32.0
  RVM         not installed
  rbenv       rbenv 1.2.0-6-g304cb7b
  chruby      not installed

Bundler Build Metadata

Built At          2021-11-08
Git SHA           2505ef8972
Released Version  true

[deivid-rodriguez]

Hi, sorry, no, from the information you have given it's not clear to me what the culprit is. I need a reproducible example, thank you!

[ojab]

Trying to craft the reproducer and (in the repo with the issue)

$ bundle info xxx
Could not find gem 'xxx', because it's in the group 'default', configured to be ignored.

:wat:

[deivid-rodriguez]

What's the result of bundle config?

[ojab]

Nothing related in my view

Settings are listed in order of priority. The top value will be used.
build.gpgme
Set for the current user (/home/ojab/.bundle/config): "--use-system-libraries"

build.nokogiri
Set for the current user (/home/ojab/.bundle/config): "--use-system-libraries"

enterprise.contribsys.com
Set for the current user (/home/ojab/.bundle/config): ":[REDACTED]"

gem.changelog
Set for the current user (/home/ojab/.bundle/config): true

gem.ci
Set for the current user (/home/ojab/.bundle/config): false

gem.coc
Set for the current user (/home/ojab/.bundle/config): false

gem.linter
Set for the current user (/home/ojab/.bundle/config): false

gem.mit
Set for the current user (/home/ojab/.bundle/config): false

gem.test
Set for the current user (/home/ojab/.bundle/config): "rspec"

gems.contribsys.com
Set for the current user (/home/ojab/.bundle/config): ":[REDACTED]"

github.com
Set for the current user (/home/ojab/.bundle/config): "ojab:[REDACTED]"

jobs
Set for the current user (/home/ojab/.bundle/config): 8

[deivid-rodriguez]

Nope. I'm at loss.

[ojab]

From: /home/ojab/.rbenv/versions/2.7.4/lib/ruby/site_ruby/2.7.0/bundler/lockfile_generator.rb:42 Bundler::LockfileGenerator#add_sources:

    30: def add_sources
    31:   definition.send(:sources).lock_sources.each_with_index do |source, idx|
    32:     out << "\n" unless idx.zero?
    33: 
    34:     # Add the source header
    35:     out << source.to_lock
    36: 
    37:     # Find all specs for this source
    38:     specs = definition.resolve.select {|s| source.can_lock?(s) }
    39:     add_specs(specs)
    40:   rescue GitError => e
    41:     binding.pry
 => 42:     raise
    43:   end
    44: end

[2] pry(#<Bundler::LockfileGenerator>)> source.to_lock
Bundler::GitError: The qgit source https://github.com/xx/xx.git is not yet checked out. Please run `bundle install` before trying to start your application
from /home/ojab/.rbenv/versions/2.7.4/lib/ruby/site_ruby/2.7.0/bundler/source/git/git_proxy.rb:226:in `allowed_with_path'
Caused by Bundler::GitError: The qgit source https://github.com/xx/xx.git is not yet checked out. Please run `bundle install` before trying to start your application
from /home/ojab/.rbenv/versions/2.7.4/lib/ruby/site_ruby/2.7.0/bundler/source/git/git_proxy.rb:226:in `allowed_with_path'

and we have

[4] pry(#<Bundler::Source::Git::GitProxy>)> @git.instance_variable_get(:@allow_remote)
=> false
[5] pry(#<Bundler::Source::Git::GitProxy>)> @git.instance_variable_get(:@allow_cached)
=> false

there

[deivid-rodriguez]

Thanks for investigating. I still don't know what's going on 😞.

[ojab]

I think I found it, the issue is gem version which is 0.0.0.SNAPSHOT. New directory with Gemfile:

# frozen_string_literal: true

source "https://rubygems.org"

git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }

gem 'tst_gem', github: 'ojab/tst_gem'

hangs locally during bundle (tst_gem has version 0.1.0.SNAPSHOT). I guess it cannot resolve it for some reason?

[ojab]

(and issue during bundle update --bundler is because of dep = @dependencies.find {|d| s.satisfies?(d) } doesn't succeed and thinks that the gem is not installed)

[12] pry(#<Bundler::Definition>)> s
=> #<Bundler::LazySpecification:0x000000000226eec0
 @__identifier=["xxx", Gem::Version.new("0.0.0.SNAPSHOT"), "\u0000"],
 @__to_s="xxx (0.0.0.SNAPSHOT)",
 @dependencies=…,
 @name="xxx",
 @platform="ruby",
 @source=#<Bundler::Source::Git:0x3260 https://github.com/yyy/xxx.git (at main@61b8918)>,
 @specification=nil,
 @version=Gem::Version.new("0.0.0.SNAPSHOT")>
[13] pry(#<Bundler::Definition>)> d
=> Gem::Dependency.new("xxx", Gem::Requirement.new([">= 0"]), :runtime)

[deivid-rodriguez]

The last issue might be fixed by #5092, can you try it?

[ojab]

Yep, installation issue is fixed, but bundle update --bundler still fails 👀

[ojab]

oh! With version 0.0.0.SNAPSHOT this one could be reproduced, check the Gemfile above.

[deivid-rodriguez]

I can't reproduce any of the issues with bundler 2.2.32 and the Gemfile above. Can you setup a Github Actions workflow where the issue can be seen?