Add build warning when rake based extension is present without rake dep... #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
commented
Apr 30, 2020
simi
force-pushed
the
check-rake-extension
branch
from
a7f230f to
7546941
Compare
Contributor
Author
|
ℹ️ not sure why some builds were cancelled. CI failures look unrelated to this change. |
Contributor
strategy:
fail-fast: false |
Contributor
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Looks very neat @simi, just a couple of minor comments.
deivid-rodriguez
approved these changes
May 9, 2020
This was referenced May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
potentially closes #3578