Use a more accurate source code uri in gemspec #5896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the bundler metadata source_code_uri Also, since `metadata` support was introduced in rubygems 2.0, and the required rubygems version is ">= 2.5.2", the check for `metadata=` support has been removed.
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
deivid-rodriguez
approved these changes
Sep 3, 2022
deivid-rodriguez
changed the title
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 7, 2022
Update bundler source code uri (cherry picked from commit 24e4e9f)
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 12, 2022
https://build.opensuse.org/request/show/1010049 by user coolo + dimstar_suse updated to version 2.3.23 see installed CHANGELOG.md # 2.3.23 (October 5, 2022) ## Enhancements: - Update GitLab CI template with new one [#5944](ruby/rubygems#5944) ## Bug fixes: - Fix `bundle init` not respecting umask in generated gem's Gemfile [#5947](ruby/rubygems#5947) ## Performance: - Further speed up Bundler by not sorting specs unnecessarily [#5868](ruby/rubygems#5868) ## Documentation: - Update Bundler new feature instructions [#5912](ruby/rubygems#5912) # 2.3.22 (September 7, 2022) ## Enhancements: - Use a more accurate source code uri in gemspec [#5896](ruby/rubygems#5896)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the bundler metadata source_code_uri
Also, since
metadatasupport was introduced in rubygems 2.0, and the required rubygems version is ">= 2.5.2", the check formetadata=support has been removed.What was the end-user or developer problem that led to this PR?
Locating the
bundlersource codeWhat is your fix for the problem, implemented in this PR?
Fix the link to the bundler source code within the bundler gemspec
Make sure the following tasks are checked