Fix Gem::Platform.match not handling String argument properly
#5939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously 9eead86 introduced non-commutativity of platforms, and later commit 1b9f7f5 changed the behavior of `Gem::Platform.match` to ensure the callee of `#=~` was the gem platform. However, when the platform argument is a String, then the callee and argument of `#=~` are flipped (see docs for `String#=~`), which works against the fix from 1b9f7f5. Closes ruby#5938
deivid-rodriguez
approved these changes
Sep 27, 2022
deivid-rodriguez
changed the title
Gem::Platform.match not handling String argument properly
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2022
…ing-arg fix: Gem::Platform.match handles String argument properly (cherry picked from commit fa391c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously 9eead86 introduced non-commutativity of platforms, and later commit 1b9f7f5 changed the behavior of
Gem::Platform.matchto ensure the callee of#=~was the gem platform.However, when the platform argument is a String, then the callee and argument of
#=~are flipped (see docs forString#=~), which works against the fix from 1b9f7f5.Closes #5938
What was the end-user or developer problem that led to this PR?
See #5938
What is your fix for the problem, implemented in this PR?
Coerce the
Gem::Platform.matchargument to aGem::PlatformobjectMake sure the following tasks are checked