Use a working setup-ruby action on Windows to get CI green #8680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/try-workaround-ci
branch
7 times, most recently
from
20a9dc4 to
ed9bf30
Compare
deivid-rodriguez
changed the title
Contributor
Author
|
Merging to get CI back on track for now. |
simi
approved these changes
May 9, 2025
deivid-rodriguez
force-pushed
the
deivid-rodriguez/try-workaround-ci
branch
2 times, most recently
from
d962949 to
0f4c8fd
Compare
New packages for ucrt64 gcc chain were uploaded to https://github.com/ruby/setup-msys2-gcc/releases/tag/msys2-gcc-pkgs recently and they seem to have broken extension compilation on Windows. There's a new rewrite of the action (unsure if related of unrelated to this issue) that makes it easier to pin to older version of the gcc chain. So this uses a fork of that rewrite that pins to gcc chain to the last working version. So switch to that for now to get our CI back to green.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/try-workaround-ci
branch
from
0a08c41 to
b92935d
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
May 13, 2025
…d-ci Use a working setup-ruby action on Windows to get CI green (cherry picked from commit e8e606b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Some CI jobs on Windows broke some hours ago.
What is your fix for the problem, implemented in this PR?
New packages with ucrt64 gcc chain were uploaded to https://github.com/ruby/setup-msys2-gcc/releases/tag/msys2-gcc-pkgs very recently and they seem to have broken extension compilation when Ruby 3.2 and Ruby 3.3 are run on Windows.
Apparently recent GCC issues have led to a rewrite of the ruby/setup-ruby action on Windows, and the rewrite does not have any issues and it's also dramatically faster.EDIT: The same issues showed up in the fork in the last few days, however, it's easier to go back to working GCC packages in the fork, so I'm still using it. And it's still much faster.
So switch to that for now to get our CI back to green.
Make sure the following tasks are checked