Skip to content

Conversation

@afurm
Copy link

@afurm afurm commented Nov 23, 2025

What was the end-user or developer problem that led to this PR?

Gem::RemoteFetcher#download has a nil-scheme branch for local file paths, but there was no test proving that a local .gem source replaces a stale cached gem. The missing coverage left a regression risk and kept a TODO in place.

What is your fix for the problem, implemented in this PR?

Added a focused test that seeds the cache with stale contents, points source_uri to a local .gem, and asserts the cache is overwritten with the local file’s contents. The change exercises the nil-scheme code path and removes the obsolete TODO.

Make sure the following tasks are checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants