Add test ensuring local gem downloads overwrite stale cache #9112
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Gem::RemoteFetcher#downloadhas a nil-scheme branch for local file paths, but there was no test proving that a local.gemsource replaces a stale cached gem. The missing coverage left a regression risk and kept a TODO in place.What is your fix for the problem, implemented in this PR?
Added a focused test that seeds the cache with stale contents, points
source_urito a local.gem, and asserts the cache is overwritten with the local file’s contents. The change exercises the nil-scheme code path and removes the obsolete TODO.Make sure the following tasks are checked