Skip to content

Keep install as the default command and print how to show the help on $ bundle #9129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep install as the default command and print how to show the help on $ bundle #9129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions bundler/lib/bundler/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,9 @@ def self.default_command(meth = nil)
default_cli_command = Bundler.settings[:default_cli_command]
return default_cli_command if default_cli_command

Bundler.ui.warn(<<~MSG)
In the next version of Bundler, running `bundle` without argument will no longer run `bundle install`.
Instead, the `help` command will be displayed.

If you'd like to keep the previous behaviour please run `bundle config set default_cli_command install --global`.
Bundler.ui.info(<<~MSG)
Running `bundle` without argument runs `bundle install`.
If you want the help, use `bundle --help`.
MSG

"install"
Expand Down
4 changes: 2 additions & 2 deletions bundler/spec/bundler/cli_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ def out_with_macos_man_workaround
end

context "with no arguments" do
it "installs and log a warning by default" do
it "installs by default and prints how to show the help" do
bundle "", raise_on_error: false
expect(err).to include("running `bundle` without argument will no longer run `bundle install`.")
expect(out).to include("If you want the help, use `bundle --help`.")
expect(err).to include("Could not locate Gemfile")
end

Expand Down