Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotations for 3.0 #157

Closed
wants to merge 1 commit into from
Closed

Conversation

okuramasafumi
Copy link
Contributor

Version numbers are not string elsewhere, but only 3.0 is a string.
This is a bit confusing so quotations has been removed.

Version numbers are not string elsewhere, but only 3.0 is a string.
This is a bit confusing so quotations has been removed.
@eregon
Copy link
Member

eregon commented Mar 5, 2021

It needs to be, see actions/runner#849.
It would be great if you can leave a comment there.
IMHO it should be fixed in GitHub Actions, but until then we should use a String for 3.0 to workaround.

@eregon eregon closed this Mar 5, 2021
@okuramasafumi
Copy link
Contributor Author

Oh I see. Then should it be commented on README so that no one sends similar PR?

@eregon
Copy link
Member

eregon commented Mar 5, 2021

Yes, that's a good idea, could you make a PR for that? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants