Add specs for the it variable in blocks #1224
Conversation
|
There are some relevant new specs in a TruffleRuby corresponding PR oracle/truffleruby#3734. So later we will need to combine them and this PR changes during synchronising TruffleRuby's spec changes with The progress of TruffleRuby support of Ruby 3.3 is tracked in oracle/truffleruby#3681. Usually contributors leave a comment when they are starting working on some item. |
|
I have updated this one with the Ruby 3.4 behaviour and rebased it upon the current state. With extra credits for @zverok, the examples on "The Ruby Changes" were very helpful. This includes the behaviour of Ruby 3.3 and 3.4, so it checks a box in #1265 as well. I put everything in |
|
Fun fact: this is the first time in the specs that matched syntax errors in Prism and Parse.y did not match up (https://bugs.ruby-lang.org/issues/21381) |
| it "acts as the first argument if no local variables exist" do | ||
| eval("proc { it * 2 }").call(5).should == 10 | ||
| end | ||
|
|
There was a problem hiding this comment.
As for me it might be useful to add tests cases similar to what we have in the 3.3...3.4 section:
it "does not emit a deprecation warning when a local variable inside the block nameditexists" doit "calls the methoditif defined" do- and probably
it "does not emit a deprecation warning when a block has parameters" do
|
|
||
| it "can be used in nested calls" do | ||
| eval("proc { it.map { it * 2 } }").call([1, 2, 3]).should == [2, 4, 6] | ||
| end |
There was a problem hiding this comment.
In this test it isn't clear whether a block for the map call has its own it variable or it refers the the it variable of the outer scope (a block for the proc call)
Yes, makes sense. |
We reported such issues usually in the ruby/prism GitHub repo. It seems the old parser (I mean parse.y) doesn't catch this issue at all and the error is emitted at YARV byte code generation (so we have printed |
| it "cannot be mixed with numbered parameters" do | ||
| -> { | ||
| eval "proc { it + _1 }" | ||
| }.should raise_error(SyntaxError, /numbered parameters are not allowed when 'it' is already used|'it' is already used in/) |
There was a problem hiding this comment.
How does this spec pass given https://bugs.ruby-lang.org/issues/21381 and the fact we have a CI job using parse.y?
In general it's probably best to just accept either message.
For #1216
This is very much a work in progress, I had this file hanging around in Natalie. It's mostly just a PoC, and misses a lot of cases. The numbered_parameters_spec can probably be used as a reference.