Skip to content

Commit

Permalink
Merge pull request #180 from ruby/schneems/mar-16-2023
Browse files Browse the repository at this point in the history
v1.0.3
  • Loading branch information
schneems authored Mar 17, 2023
2 parents a22c870 + fbae9e3 commit eab40be
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ jobs:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: test
run: bundle exec rake test
run: RUBYOPT="--disable=syntax_suggest" bundle exec rake test
continue-on-error: ${{ matrix.ruby == 'head' }}
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## HEAD (unreleased)

## 1.0.3

- Output improvement: Handle methods with only newlines or comments in them (https://github.com/ruby/syntax_suggest/pull/179)
- No longer shows the detail of monkey patch as the document (https://github.com/ruby/syntax_suggest/pull/174)
- Drop CI for Ruby 3.2.0-rc1, now that 3.2.0 is available (https://github.com/ruby/syntax_suggest/pull/172)
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
syntax_suggest (1.0.2)
syntax_suggest (1.0.3)

GEM
remote: https://rubygems.org/
Expand Down
2 changes: 1 addition & 1 deletion lib/syntax_suggest/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module SyntaxSuggest
VERSION = "1.0.2"
VERSION = "1.0.3"
end
18 changes: 18 additions & 0 deletions spec/integration/ruby_command_line_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,24 @@ module SyntaxSuggest
end
end

# Since Ruby 3.2 includes syntax_suggest as a default gem, we might accidentally
# be requiring the default gem instead of this library under test. Assert that's
# not the case
it "tests current version of syntax_suggest" do
Dir.mktmpdir do |dir|
tmpdir = Pathname(dir)
script = tmpdir.join("script.rb")
contents = <<~'EOM'
puts "suggest_version is #{SyntaxSuggest::VERSION}"
EOM
script.write(contents)

out = `#{ruby} -I#{lib_dir} -rsyntax_suggest #{script} 2>&1`

expect(out).to include("suggest_version is #{SyntaxSuggest::VERSION}").once
end
end

it "detects require error and adds a message with auto mode" do
Dir.mktmpdir do |dir|
tmpdir = Pathname(dir)
Expand Down

0 comments on commit eab40be

Please sign in to comment.