Decouple Capture Context tests #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make all heredocs literal - Remove unused test
The "capture code context spec" currently depends on code search which can change as the algorithm evolves. This makes development hard since it's unclear when those tests fail if it's because the functionality changed or the search output changed. Also since the existing "capture context" logic is based on quirks of how the code search algorithm works, when the search is improved it may need different "capture context" logic before it produces good output. For these cases, we actually need to duplicate the tests 3 times. - Integration with everything - Capture Code Context works with static input - CodeSearch produces the static input we expect So when all 3 start failing then we can look at it in isolation and see if it "makes sense". I.e. if the CodeSearch output actually "improved" but the integration and capture context are failing then we need to write new logic.
schneems
force-pushed
the
schneems/tame-some-tests
branch
from
3d65609 to
514d683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "capture code context spec" currently depends on code search which can change as the algorithm evolves. This makes development hard since it's unclear when those tests fail if it's because the functionality changed or the search output changed. Also since the existing "capture context" logic is based on quirks of how the code search algorithm works, when the search is improved it may need different "capture context" logic before it produces good output.
For these cases, we actually need to duplicate the tests 3 times.
So when all 3 start failing then we can look at it in isolation and see if it "makes sense". I.e. if the CodeSearch output actually "improved" but the integration and capture context are failing then we need to write new logic.