Update ruby versions to test #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
approved these changes
Jun 14, 2023
Collaborator
schneems
left a comment
schneems
left a comment
There was a problem hiding this comment.
This is a note for what's happening: I was curious about what this workflow does https://github.com/ruby/actions/blob/cf3a31799796546281e6fe21ab4d2bd8e965caed/.github/workflows/ruby_versions.yml. It pulls down a json file based on the Ruby engine. In this case it uses cruby specified below. The json file is:
["3.0","3.1","3.2","head"]
Then it uses that file to specify versions to test.
This change will bump min supported Ruby version (on CI) from 2.5 to 3.0 to match Ruby non-eol versions. I'm good with that, I think I want to make this a major version bump and also specify minimum Ruby version to match CI.
I'm on a plane so approving without merge. Can you confirm my above interpretation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.