[Close #21] Concat lines with trailing slash #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby lines that end with a slash `\` indicate that the next line should be concatenated with the current line so:
```ruby
if "trailing" \
"line" do
end
```
Is functionally equivalent to:
```ruby
if "trailing" "line" do
endf
```
We can replicate this logic by taking note when a line ends with a trailing slash and then concatenating it with the next line.
Functionally the TrailingSlashJoin class does this by concatenating the lines, and then hiding the original line.
To allow for output, the DisplayCodeWithLineNumbers is now aware that a code line may contain multiple code lines, and it will split and render each.
schneems
force-pushed
the
schneems/trailing-do
branch
from
8f6083f to
4853d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby lines that end with a slash
\indicate that the next line should be concatenated with the current line so:Is functionally equivalent to:
We can replicate this logic by taking note when a line ends with a trailing slash and then concatenating it with the next line.
Functionally the TrailingSlashJoin class does this by concatenating the lines, and then hiding the original line.
To allow for output, the DisplayCodeWithLineNumbers is now aware that a code line may contain multiple code lines, and it will split and render each.