[close #50] Less greedy unmatched kw capture #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described in #32 we are capturing the correct code blocks, however if the problem is mis-matched keyword, then the internals of the block are incorrectly hidden.
Code was added to work backwards and show that extra mis-matched keyword, unfortunately it grabbed more and caused a less-than-ideal output:
Before:
Instead of digging into the problem with the existing code, I re-wrote it from scratch. I've frankly got no idea why it was broken previously, but the prior code didn't make much sense. This new version is much simpler and with added comments, fairly straightforward.
After: