Skip to content

Let -v respond with gem version instead of 'unknown' #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

Let -v respond with gem version instead of 'unknown' #82

merged 1 commit into from
Oct 13, 2021

Conversation

@mauro-oto
Copy link
Contributor

@mauro-oto mauro-oto commented Oct 13, 2021 •
edited
Loading

This is what was printed before:

➜  dead_end git:(main) ✗ dead_end --version
dead_end: version unknown

Now we get the actual gem version in the output:

➜  dead_end git:(main) ✗ dead_end --version
dead_end 2.0.0
➜  dead_end git:(main) ✗ dead_end -v
dead_end 2.0.0

@mauro-oto mauro-oto requested a review from schneems October 13, 2021 00:49
@mauro-oto
Let -v respond with gem version instead of 'unknown'
5d196e3 
This is what was printed before:
```
➜  dead_end git:(main) ✗ dead_end --version
dead_end: version unknown
```

Now we get the actual gem version in the output.
@mauro-oto mauro-oto force-pushed the mauro-oto/gem-version-on-cli branch from 05cc105 to 5d196e3 Compare October 13, 2021 00:51
@schneems
Copy link
Collaborator

schneems commented Oct 13, 2021

Nice. Thanks!

@schneems schneems merged commit 52d4c7e into main Oct 13, 2021
@schneems schneems deleted the mauro-oto/gem-version-on-cli branch October 13, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schneems schneems Awaiting requested review from schneems

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mauro-oto @schneems