Fix double output #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we proxy `Object.load` to `Kernel.load` we were firing `DeadEnd.handle_error` twice. Switching the test over to a `load` instead of a `require_relative` makes the error show up, which can then be asserted via adding the `once` call in rspec. I still don't know why this code was needed in the first place. close #97
schneems
force-pushed
the
schneems/double-trouble
branch
from
c2d2005 to
42cb5e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we proxy
Object.loadtoKernel.loadwe were firingDeadEnd.handle_errortwice. Switching the test over to aloadinstead of arequire_relativemakes the error show up, which can then be asserted via adding theoncecall in rspec.I still don't know why this code was needed in the first place.
close #97