Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI::REGEXP::PATTERN::IPV6ADDR no longer available in 1.0.1 #131

Closed
jordan-brough opened this issue Nov 12, 2024 · 2 comments · Fixed by #132
Closed

URI::REGEXP::PATTERN::IPV6ADDR no longer available in 1.0.1 #131

jordan-brough opened this issue Nov 12, 2024 · 2 comments · Fixed by #132

Comments

@jordan-brough
Copy link

The cookiejar gem used URI::REGEXP::PATTERN::IPV6ADDR and URI::REGEXP::PATTERN:: IPV4ADDR from uri versions < 1.0.0.

Now the library raises this exception:

uninitialized constant CookieJar::CookieValidation::PATTERN::IPV4ADDR

Because this code is failing:

  module CookieValidation
    module PATTERN
      include URI::REGEXP::PATTERN
      ...
      IPADDR = "#{IPV4ADDR}|#{IPV6ADDR}".freeze

see here.

Would it be possible to restore and deprecate those constants? The cookiejar project is archived so replacing it will take some work.

jordan-brough added a commit to jordan-brough/em-http-request that referenced this issue Nov 12, 2024
The "uri" gem was updated last week and the new version has an incompatibility with the "cookiejar" library.

See ruby/uri#131
jordan-brough added a commit to jordan-brough/em-http-request that referenced this issue Nov 12, 2024
The "uri" gem was updated last week and the new version has an incompatibility with the "cookiejar" library.

See ruby/uri#131
@hsbt
Copy link
Member

hsbt commented Nov 13, 2024

Thank you for your report.

How about #132? That test-case covered your issues.

@hsbt hsbt closed this as completed in #132 Nov 14, 2024
@jordan-brough
Copy link
Author

Thank you for the quick response @hsbt! The update seems to be working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants