Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space after bad URI #37

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add space after bad URI #37

merged 1 commit into from
Aug 5, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 29, 2022

I'm running dkhamsing/awesome_bot:1.20.0 and it generated things like:

bad URI(is not URI?): "http://nginx.org/en/docs/http/ngx_http_map_module.html#map](http://nginx.org/en/docs/http/ngx_http_map_module.html"

@hsbt
Copy link
Member

hsbt commented Apr 19, 2024

I'm not sure what is the problem without space. Can you share more details?

@setharnold
Copy link

Hey @hsbt, the typical English custom is to put a space before an opening parenthesis and a space after a closing parenthesis. Bad URI (is not URI?) feels much more natural than Bad URI(is not URI?).

There can be some nuance around the right spacing in different situations (see https://english.stackexchange.com/a/6047 for a nice example). In this case I think it'd be easier to read with the space.

Thanks

@hsbt hsbt merged commit 4b723f5 into ruby:master Aug 5, 2024
24 checks passed
@hsbt
Copy link
Member

hsbt commented Aug 5, 2024

I understood. Thanks @setharnold

@jsoref jsoref deleted the bad-uri-space branch August 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants