Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and improve #152

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Fix bugs and improve #152

merged 4 commits into from
Nov 5, 2024

Conversation

znz
Copy link
Member

@znz znz commented Oct 31, 2024

This PR improves some codes that I found when I was adding RBS.

  • Remove an unused instance variable.
  • Fix some typos.
  • req.addr and req.peeraddr initialize [] instead of nil, so those types can be non-nil.
  • v1, v2 = split(sep) should be v1, v2 = split(sep, 2).

@ioquatix ioquatix merged commit cb93ef8 into master Nov 5, 2024
38 checks passed
@ioquatix ioquatix deleted the fix-bugs-and-improve branch November 5, 2024 04:01
@nate2014jatc nate2014jatc mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znz @ioquatix