Skip to content

Drop mention of old OS X versions (id) #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Drop mention of old OS X versions (id) #1686

wants to merge 1 commit into from

Conversation

meisyal
Copy link
Contributor

@meisyal meisyal commented Nov 2, 2017

As mentioned on 9e7c14d, the old version of OS X should not be mentioned.

@meisyal meisyal requested a review from goz November 2, 2017 23:45
goz
goz approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@goz goz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sugoi 👍

thanks @meisyal

@stomar
Copy link
Contributor

stomar commented Nov 3, 2017

There are more changes in preparation, e.g. #1681 and #1682, or already applied, e.g. dc375e4. Let‘s wait and apply them all at once.

@meisyal
Copy link
Contributor Author

meisyal commented Mar 8, 2019

Hi @stomar, changes on #1681 and #1682 have been applied. I checked this PR is outdated because the Installation page has been updated a lot recently. Should I close this PR and create a new one?

@stomar
Copy link
Contributor

stomar commented Mar 8, 2019

As you like, I guess you could either amend with the updated Homebrew section, or open a new PR for the complete installation page.

@meisyal
Copy link
Contributor Author

meisyal commented Mar 9, 2019

I think it's better to open a new pull request for complete installation page. So, I close this PR @stomar.

@meisyal meisyal closed this Mar 9, 2019
@meisyal meisyal deleted the patch-1 branch March 9, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goz goz goz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meisyal @stomar @goz