Skip to content

Update spelling of “macOS” #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

Update spelling of “macOS” #1835

merged 1 commit into from
Dec 3, 2018

Conversation

sonicdoe
Copy link
Contributor

@sonicdoe sonicdoe commented Oct 3, 2018

If you’re okay with this change, I can update the other languages as well.

@JuanitoFatas
Copy link
Member

If you’re okay with this change, I can update the other languages as well.

This looks good, please include other languages 👍

@sonicdoe
Copy link
Contributor Author

sonicdoe commented Oct 5, 2018

Done 👍

@olivierlacan olivierlacan mentioned this pull request Nov 16, 2018
Merged
8 tasks
@olivierlacan
Copy link
Contributor

@sonicdoe I apologize for causing this conflict but you might need to rebase against master since #1877 was merged. Thanks for your work. 🙇

yous
yous reviewed Nov 16, 2018
View reviewed changes
@sonicdoe sonicdoe requested review from a team as code owners November 16, 2018 16:36
@sonicdoe
Copy link
Contributor Author

@olivierlacan Thanks for the heads-up, it’s rebased now.
@yous Thanks for your help, I’ve incorporated your suggestions.

@sonicdoe @yous
Update spelling of “macOS”
18ecf45 
Co-Authored-By: Chayoung You <yousbe@gmail.com>
yous
yous reviewed Nov 16, 2018
View reviewed changes
Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ko/ directory.

kennyadsl
kennyadsl approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok!

@JuanitoFatas
Copy link
Member

@bugtender @dsh0416 Could you review the Chinese content? 🙏

@riseshia riseshia mentioned this pull request Nov 17, 2018
Merged
meisyal
meisyal reviewed Nov 17, 2018
View reviewed changes
Copy link
Contributor

@meisyal meisyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK for id. Thanks for making changes.

bugtender
bugtender approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in Chinese. Thanks. 👍

@JuanitoFatas JuanitoFatas merged commit dfa7e9d into ruby:master Dec 3, 2018
@JuanitoFatas
Copy link
Member

@sonicdoe Fantastic work! Thanks Jakob and everyone who reviews, comments 🎉

@sonicdoe sonicdoe deleted the macos-spelling branch December 3, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yous yous yous left review comments

@meisyal meisyal meisyal left review comments

@kennyadsl kennyadsl kennyadsl approved these changes

@bugtender bugtender bugtender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sonicdoe @JuanitoFatas @olivierlacan @kennyadsl @yous @meisyal @bugtender