Skip to content

Translate fukuoka-ruby-award 2019 (ko) #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 25, 2018

Conversation

riseshia
Copy link
Member

Ref: #1894

Translation of #1897

Check a87ef3c for review, @ruby/www-ruby-lang-org-i18n-ko 🙏

@riseshia riseshia requested a review from a team as a code owner December 23, 2018 13:13

* salesforce.com의 기념품

'Matz는 코드를 주의깊게 테스트하고 읽어볼 것이므로, 지원할만한 충분한 가치가 있을 것입니다! 대회에 참가하는 것은 무료입니다.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Matz는 코드를 주의깊게 테스트하고 읽어볼 것이므로, 지원할만한 충분한 가치가 있을 것입니다! 대회에 참가하는 것은 무료입니다.'
'Matz'는 코드를 주의깊게 테스트하고 읽어볼 것이므로, 지원할만한 충분한 가치가 있을 것입니다! 대회참가는 무료입니다.'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matz'는?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and fixed last one 47515e2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think surrounding this line with " would be more appropriate than '. How do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed this one, #1872 (comment)
Is there any reason you suggest to use " here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read the rules once again. At first I thought this is a quotation, but it's not. Using ' seems right. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. It was pair with end of line. My miss read.

marocchino and others added 2 commits December 25, 2018 09:23
Co-Authored-By: riseshia <rise.shia@gmail.com>
/대회에 참가하는 것은/대회참가는/
@riseshia riseshia changed the title [KO] Translate fukuoka-ruby-award 2019 Translate fukuoka-ruby-award 2019 (ko) Dec 25, 2018
yous and others added 2 commits December 25, 2018 12:08
Co-Authored-By: riseshia <rise.shia@gmail.com>
Co-Authored-By: riseshia <rise.shia@gmail.com>
Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@riseshia riseshia merged commit 68a659e into ruby:master Dec 25, 2018
@riseshia riseshia deleted the fukuoka-ruby-2019 branch December 25, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants