Skip to content

Update blog section (ko) #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 1, 2019
Merged

Update blog section (ko) #1942

merged 7 commits into from
Jan 1, 2019

Conversation

riseshia
Copy link
Member

@riseshia riseshia commented Jan 1, 2019 •
edited
Loading

Follow up #1889
Ref #1894

Check 85faedf, a96ba02, 56a9c9f for actual diff
@ruby/www-ruby-lang-org-i18n-ko Please review this 🙏

@riseshia riseshia requested a review from a team as a code owner January 1, 2019 02:39
@yous yous mentioned this pull request Jan 1, 2019
Closed
yous
yous reviewed Jan 1, 2019
View reviewed changes
yous and others added 2 commits January 1, 2019 12:39
@yous @riseshia
Apply suggestions from code review
25d5c75 
Co-Authored-By: riseshia <rise.shia@gmail.com>
Better translation
b9fea20
yous
yous approved these changes Jan 1, 2019
View reviewed changes
Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@riseshia
Copy link
Member Author

riseshia commented Jan 1, 2019

Thanks for review. Happy new year! 🎉

@riseshia riseshia merged commit 0328087 into ruby:master Jan 1, 2019
@riseshia riseshia deleted the blog-update-ko branch January 1, 2019 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yous yous yous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riseshia @yous