Skip to content

Translate Ruby Community Conduct Guideline (ko) #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2019
Merged

Translate Ruby Community Conduct Guideline (ko) #1946

merged 3 commits into from
Jan 15, 2019

Conversation

riseshia
Copy link
Member

@riseshia riseshia commented Jan 7, 2019

Ref: #1894

Actual diff is 1f3c22e

Please review this @ruby/www-ruby-lang-org-i18n-ko 🙏

@riseshia riseshia requested a review from a team as a code owner January 7, 2019 23:29
@yous yous mentioned this pull request Jan 14, 2019
Closed
yous
yous reviewed Jan 14, 2019
View reviewed changes
Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yous @riseshia
Apply suggestions from code review
2042c98 
Co-Authored-By: riseshia <rise.shia@gmail.com>
@riseshia
Copy link
Member Author

Reviews are applied in 2042c98 🙇

yous
yous approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@riseshia riseshia merged commit c3e2ff6 into ruby:master Jan 15, 2019
@riseshia riseshia deleted the conduct-ko branch January 15, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yous yous yous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riseshia @yous