Skip to content

Editor list fixes in more languages #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 10, 2019
Merged

Editor list fixes in more languages #1968

merged 17 commits into from
Feb 10, 2019

Conversation

jacobherrington
Copy link
Contributor

This PR is a continuation of #1965

@jacobherrington jacobherrington requested review from a team as code owners February 9, 2019 18:06
@jacobherrington
Copy link
Contributor Author

Following up on one of my past PRs @JuanitoFatas.

yous
yous reviewed Feb 9, 2019
View reviewed changes
Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ko directory is LGTM.

bugtender
bugtender approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the zh_tw. 👍

@JuanitoFatas JuanitoFatas merged commit d4e30a6 into ruby:master Feb 10, 2019
@JuanitoFatas
Copy link
Member

thanks everyone!

@riseshia riseshia mentioned this pull request Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yous yous yous left review comments

@bugtender bugtender bugtender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobherrington @JuanitoFatas @yous @bugtender