Skip to content

Minor language fix on Aug 28th, 2019 release #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 28, 2019
Merged

Minor language fix on Aug 28th, 2019 release #2128

merged 9 commits into from
Aug 28, 2019

Conversation

sorah
Copy link
Member

@sorah sorah commented Aug 28, 2019

No description provided.

@sorah sorah requested review from a team as code owners August 28, 2019 12:07
@sorah sorah force-pushed the rel0828-languagefix branch from 57fe514 to d7c93dc Compare August 28, 2019 12:08
@sorah sorah force-pushed the rel0828-languagefix branch from d7c93dc to 710f218 Compare August 28, 2019 12:10
mame
mame approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@mame mame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorah sorah mentioned this pull request Aug 28, 2019
Closed
@sorah sorah force-pushed the rel0828-languagefix branch from 7bd3c04 to f1d67a7 Compare August 28, 2019 12:32
@sorah sorah merged commit 1c04d33 into ruby:master Aug 28, 2019
@sorah sorah deleted the rel0828-languagefix branch August 28, 2019 12:33
@yous yous mentioned this pull request Aug 28, 2019
Closed
@yous yous mentioned this pull request Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mame mame mame approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorah @mame