Skip to content

Fixes broken build from source link #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

srcoley
Copy link
Contributor

@srcoley srcoley commented Oct 18, 2022

Resolves issue #2864.

This change fixes a broken link on the en, es, id, ko, and tr Installation pages. I've updated the link text for the English version, but am unable to translate for the other languages.

The links now point to https://github.com/ruby/ruby/blob/master/doc/contributing/building_ruby.md instead of the broken https://github.com/ruby/ruby#how-to-compile-and-install

Translations:

  • en
  • es
  • id
  • ko
  • tr

Affected languages: en, es, id, ko, and tr.

English link text has been updated. The others will need translations.
@srcoley srcoley requested review from a team as code owners October 18, 2022 15:28
@yous
Copy link
Member

yous commented Oct 18, 2022

For ko: [Ruby README 파일][readme]에서[Ruby 빌드하기 문서][readme]에서

@ruby/www-ruby-lang-org-i18n-ko How do you think?

@srcoley srcoley changed the title Fixes broken install from source link Fixes broken build from source link Oct 18, 2022
@gfvcastro
Copy link
Member

gfvcastro commented Oct 18, 2022

From a @ruby/www-ruby-lang-org-i18n-es perspective, I think we should update:

Puedes encontrar más información acerca de compilar desde fuente en el

It should be:

Puedes encontrar más información acerca de cómo compilar el código fuente en las
[Instrucciones de compilación de Ruby][readme].

What do you think @vtamara @dabit?

@dabit
Copy link
Member

dabit commented Oct 18, 2022

Puedes encontrar más información acerca de cómo compilar el
codigo fuente en las...

@srcoley
Copy link
Contributor Author

srcoley commented Oct 18, 2022

I pushed a commit to include translation suggestions for es from @gfvcastro / @dabit and ko from @yous. Thank you.

@meisyal
Copy link
Contributor

meisyal commented Oct 19, 2022

I suggest to update this following line for id translation.

Untuk mengubahnya, tambahkan opsi `--prefix=DIR` di dalam skrip `./configure`.
 
 Anda dapat menemukan informasi lebih lanjut terkait membangun dari kode
-sumber pada [Ruby README file][readme].
+sumber pada [instruksi membangun Ruby][readme].
 
 Meskipun begitu, menggunakan alat bantu pihak ketiga atau *package manager*
 mungkin adalah solusi yang terbaik, karena Ruby yang terpasang tidak akan

Any feedback @goz?

@gfvcastro gfvcastro requested a review from a team October 21, 2022 00:52
Copy link
Member

@enderahmetyurt enderahmetyurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tr: [Ruby README dosyası][readme]nda bulabilirsiniz. -> [Ruby oluşturma talimatları][readme]nda bulabilirsiniz.

@srcoley
Copy link
Contributor Author

srcoley commented Oct 21, 2022

Translations for id and tr are in place. Thanks everyone for the suggestions!

Copy link
Member

@gfvcastro gfvcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants